Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ART-10881 Store Brew bundle builds in BigQuery #990

Closed
wants to merge 1 commit into from
Closed

ART-10881 Store Brew bundle builds in BigQuery #990

wants to merge 1 commit into from

Conversation

locriandev
Copy link
Contributor

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from locriandev. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@locriandev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 30e8a3f link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

thegreyd
thegreyd reviewed Sep 27, 2024
View reviewed changes
doozer/doozerlib/cli/olm_bundle.py
build_record_params.update({
'version': build_info['version'],
'release': build_info['release'],
'el_target': f'el{isolate_el_version_in_release(build_info["release"])}',
Copy link
Contributor

@thegreyd thegreyd Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'el_target': f'el{isolate_el_version_in_release(build_info["release"])}',
'el_target': f'el{isolate_el_version_in_release(build_info["version"])}', # the way we construct nvr for bundle builds, el version is in "version"

vfreex
vfreex reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@vfreex vfreex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. After you address the issue that Sid's pointed out, I am ok with merging this.

@locriandev
Copy link
Contributor Author

/hold

It's being discussed if bundle builds should have their own table, as we might want to store operands NVRs and image labels (e.g., com.redhat.delivery.prerelease)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
@locriandev
Copy link
Contributor Author

Superseded by #995

@locriandev locriandev closed this Oct 1, 2024
@locriandev locriandev deleted the bundle-builds-to-bigquery branch October 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfreex vfreex vfreex left review comments

@thegreyd thegreyd thegreyd left review comments

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locriandev @thegreyd @vfreex